Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove methods that gets project and members by UUID #2346



Copy link

@mpro7 mpro7 commented Dec 19, 2022

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1572

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Copy link

swarmia bot commented Dec 19, 2022

✅  Linked to Story DEV-1572 · Remove method that gets project and members by UUID
➡️  Part of Epic DEV-1403 · Project UUIDs

@mpro7 mpro7 self-assigned this Dec 19, 2022
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 86.68% // Head: 86.44% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (7c9f714) compared to base (26e9596).
Patch coverage: 39.06% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
- Coverage   86.68%   86.44%   -0.25%     
  Files         250      264      +14     
  Lines       28252    28385     +133     
+ Hits        24490    24537      +47     
- Misses       3762     3848      +86     
Impacted Files Coverage Δ
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...main/scala/org/knora/webapi/config/AppConfig.scala 82.97% <0.00%> (+1.34%) ⬆️
.../main/scala/org/knora/webapi/core/HttpServer.scala 100.00% <ø> (ø)
...main/scala/org/knora/webapi/core/HttpServerZ.scala 0.00% <0.00%> (ø)
.../knora/webapi/core/InstrumentationHttpServer.scala 0.00% <0.00%> (ø)
.../knora/webapi/http/handler/ExceptionHandlerZ.scala 0.00% <0.00%> (ø) 0.00% <0.00%> (ø)
...nora/webapi/instrumentation/health/HealthApp.scala 0.00% <0.00%> (ø)
.../knora/webapi/instrumentation/index/IndexApp.scala 0.00% <0.00%> (ø)
...api/instrumentation/prometheus/PrometheusApp.scala 0.00% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mpro7 mpro7 changed the title refactor: remove method that gets project and members by UUID refactor: remove methods that gets project and members by UUID Dec 19, 2022
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@mpro7 mpro7 removed the request for review from seakayone December 19, 2022 11:01
@mpro7 mpro7 merged commit 2c8da6c into main Dec 19, 2022
11 checks passed
@mpro7 mpro7 deleted the DEV-1572-remove-method-that-gets-project-and-members-by-uuid branch December 19, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants