refactor: Extract common code from responders into EntityAndClassIriS…

[seakayone]

Pull Request Checklist

Task Description/Number

• Introduce ProjectsAdminService as at first a wrapper around its own instances of the ProjectsResponderADM exposing the method used in the zio http route
• Extract EntityAndClassIriService as dedicated service allowing for breaking up the inheritance hierachy
• Introduce ActorDeps as a zio layer - a class encapsulating all Akka dependencies necessary to interact with the [[org.knora.webapi.core.actors.RoutingActor]] aka. "appActor"
• Introduce ActorToZioBridge encapsulating the akka.pattern.ask into the zio world
• Add zio-mock dependency to test dependencies
• Replace use of methods on abstract Responder and use EntityAndClassIriService
• Remove commented out code
• Move handleUnexpectedMessage method into Responder and make protected
• Expose get single project responder as ProjectsService to ProjectRouteZ
• Add scaladoc
• Formatting

Basic Requirements

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix: represents bug fixes
• Refactor: represents production code refactoring
• Feature: represents a new feature
• Documentation: documentation changes (no production code change)
• Chore: maintenance tasks (no production code change)
• Style: styles updates (no production code change)
• Test: all about tests: adding, refactoring tests (no production code change)
• Other... Please describe:

Does this PR introduce a breaking change?

• Yes
• No

Does this PR change client-test-data?

• Yes (don't forget to update the JS-LIB team about the change)
• No

[codecov]

Codecov Report

Base: 86.68% // Head: 86.37% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (5acf8c1) compared to base (26e9596).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 5acf8c1 differs from pull request most recent head c3da43a. Consider uploading reports for the commit c3da43a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
- Coverage   86.68%   86.37%   -0.32%     
==========================================
  Files         250      268      +18     
  Lines       28252    28317      +65     
==========================================
- Hits        24490    24458      -32     
- Misses       3762     3859      +97     

Impacted Files	Coverage Δ
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala	93.93% <100.00%> (+0.12%)	⬆️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala	90.27% <100.00%> (+0.27%)	⬆️
.../scala/org/knora/webapi/responders/Responder.scala	75.00% <0.00%> (-16.43%)	⬇️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala	88.27% <0.00%> (-5.79%)	⬇️
.../webapi/messages/util/rdf/jenaimpl/JenaModel.scala	86.42% <0.00%> (-2.86%)	⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala	64.93% <0.00%> (-1.74%)	⬇️
...ebapi/store/cache/impl/CacheServiceRedisImpl.scala	56.12% <0.00%> (-1.16%)	⬇️
...la/org/knora/webapi/messages/StringFormatter.scala	88.72% <0.00%> (-0.80%)	⬇️
...api/responders/admin/PermissionsResponderADM.scala	90.16% <0.00%> (-0.04%)	⬇️
webapi/src/main/scala/org/knora/webapi/Main.scala	0.00% <0.00%> (ø)
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mpro7]

Overall looks good. There are few typos - see my comments/suggestions. Wouldn't also make sense to write some unit tests for stuff you have moved to separated services?

[seakayone]

Overall looks good. There are few typos - see my comments/suggestions.
Thanks for fixing that.

Wouldn't also make sense to write some unit tests for stuff you have moved to separated services?

In general I agree that new code should be covered with unit tests. I will look into if I can improve the coverage. However, I will have to look into if testing the EntityAndClassIriService (it is sending stuff to our actor) with zio-test is worth the effort.

[irinaschubert]

LGTM, just some suggestions regarding documentation / naming. In general, I agree with Marcin that we should have tests - if possible.

[mpro7]

Just found one minor thing while you were broadcasting.