Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add BEOL exception to UUID validation (DEV-1570) #2349


Copy link

@mpro7 mpro7 commented Dec 20, 2022

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1570

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@mpro7 mpro7 self-assigned this Dec 20, 2022
Copy link

linear bot commented Dec 20, 2022

DEV-1570 Copy/Clone resource in DSP-APP


To create a new resource, the user must fill in an empty form.

If a user wants to create a resource with almost the same values as another one, he cannot duplicate the orignal resource but must fill in one more time the entire form, or to complete the fields in the resource viewer.

Story Statement

As a project member I want to clone resources so that i can work more efficient, when I have several resources with almost the same values

Acceptance Criteria

  • The Duplicate function is just available when the user is logged in
  • You have the option to clone a resource if you have the appropriate resource open

  • When you click on “duplicate” it opens the “create new resource” context. But the first step to choose the project and the ontology will be skipped.
    • You are able to go Back but the fields Project, data model and resource type are read only and you are not able to change them
  • Images, documents, audios, videos and archives will not be adopted
  • The label will be adopted but it gets the prefix"Copy_".
  • All other values are taken 1:1 from the duplicated resource
    • The user is able to edit them

Flow / Mockup

Copy link

swarmia bot commented Dec 20, 2022

✅  Linked to Story DEV-1570 · Add BEOL exception to UUID validation
➡️  Part of Epic DEV-1403 · Project UUIDs

Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 86.68% // Head: 86.44% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (bf80210) compared to base (26e9596).
Patch coverage: 43.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2349      +/-   ##
- Coverage   86.68%   86.44%   -0.24%     
  Files         250      264      +14     
  Lines       28252    28389     +137     
+ Hits        24490    24541      +51     
- Misses       3762     3848      +86     
Impacted Files Coverage Δ
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...main/scala/org/knora/webapi/config/AppConfig.scala 82.97% <0.00%> (+1.34%) ⬆️
.../main/scala/org/knora/webapi/core/HttpServer.scala 100.00% <ø> (ø)
...main/scala/org/knora/webapi/core/HttpServerZ.scala 0.00% <0.00%> (ø)
.../knora/webapi/core/InstrumentationHttpServer.scala 0.00% <0.00%> (ø)
.../knora/webapi/http/handler/ExceptionHandlerZ.scala 0.00% <0.00%> (ø) 0.00% <0.00%> (ø)
...nora/webapi/instrumentation/health/HealthApp.scala 0.00% <0.00%> (ø)
.../knora/webapi/instrumentation/index/IndexApp.scala 0.00% <0.00%> (ø)
...api/instrumentation/prometheus/PrometheusApp.scala 0.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@mpro7 mpro7 merged commit ed34df1 into main Dec 21, 2022
11 checks passed
@mpro7 mpro7 deleted the DEV-1570-remove-uuid-validation-from-everywhere-but-project-creation branch December 21, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants