feat: introduction of not-exists operator (DEV-1845) #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalduinLandolt
approved these changes
Mar 27, 2023
Comment on lines
+326
to
+364
| // it('should set the correct comparison operators for a linking property type (on top level)', () => { | ||
| // const resProps = MockOntology.mockReadOntology( | ||
| // 'http://0.0.0.0:3333/ontology/0001/anything/v2' | ||
| // ).getPropertyDefinitionsByType(ResourcePropertyDefinition); | ||
| // | ||
| // testHostComponent.propertyDef = resProps.filter( | ||
| // (propDef) => | ||
| // propDef.id === | ||
| // 'http://0.0.0.0:3333/ontology/0001/anything/v2#hasOtherThing' | ||
| // )[0]; | ||
| // | ||
| // testHostFixture.detectChanges(); | ||
| // | ||
| // expect( | ||
| // testHostComponent.specifyProperty.comparisonOperators.length | ||
| // ).toEqual(5); | ||
| // expect(testHostComponent.topLevel).toBeTrue(); | ||
| // }); | ||
|
|
||
| // it('should set the correct comparison operators for a linking property type (not on top level)', () => { | ||
| // const resProps = MockOntology.mockReadOntology( | ||
| // 'http://0.0.0.0:3333/ontology/0001/anything/v2' | ||
| // ).getPropertyDefinitionsByType(ResourcePropertyDefinition); | ||
| // | ||
| // testHostComponent.propertyDef = resProps.filter( | ||
| // (propDef) => | ||
| // propDef.id === | ||
| // 'http://0.0.0.0:3333/ontology/0001/anything/v2#hasOtherThing' | ||
| // )[0]; | ||
| // | ||
| // testHostComponent.topLevel = false; | ||
| // | ||
| // testHostFixture.detectChanges(); | ||
| // | ||
| // expect( | ||
| // testHostComponent.specifyProperty.comparisonOperators.length | ||
| // ).toEqual(4); | ||
| // expect(testHostComponent.topLevel).toBeFalse(); | ||
| // }); |
There was a problem hiding this comment.
I don't know about you frontend friends... but we tend to not want commented-out code in our codebase
There was a problem hiding this comment.
You are right. It does not look good. As soon as the mystery with the linking property is solved, it will be uncommented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1845
Note: The case for linking properties (including unit tests) is commented out and will be activated later (DEV-1966)