Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reset buttons with cancel button #284

Merged
merged 1 commit into from Aug 18, 2020

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Aug 17, 2020

https://dasch.myjetbrains.com/youtrack/issue/DSP-546

In this PR I replaced the reset buttons in forms like:

  • project-form
  • user-form
  • list-form

We had some issues with the reset button in combination with stringLiteralInput and list of keywords. So, I replaced reset with cancel which closes the dialog box without doing anything on the form data. I kept the method reset() to go back to reset-button and to fix the issues we had. But at the moment I do not have time to fix it. We can discuss if we should get rid of the reset functionality completely... In this case I will try to refactor the relevant forms

@kilchenmann kilchenmann self-assigned this Aug 17, 2020
@kilchenmann kilchenmann requested a review from flavens Aug 17, 2020
@kilchenmann kilchenmann merged commit 1481018 into master Aug 18, 2020
2 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-546-fix-reset-buttons branch Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants