Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select-resource-class): allow accented character (DSP-1241) #363

Merged
merged 2 commits into from Jan 20, 2021

Conversation

@flavens
Copy link
Collaborator

@flavens flavens commented Jan 19, 2021

Resolves DSP-1241

@flavens flavens self-assigned this Jan 19, 2021
@flavens flavens requested a review from mdelez Jan 19, 2021
Copy link
Contributor

@mdelez mdelez left a comment

It might be better to use ranges instead of hardcoded values here unless we only want support for german and french in which case you might also want to add ß. https://stackoverflow.com/a/26900132
https://en.wikipedia.org/wiki/List_of_Unicode_characters#Basic_Latin

Loading

@flavens flavens requested a review from mdelez Jan 19, 2021
mdelez
mdelez approved these changes Jan 20, 2021
Copy link
Contributor

@mdelez mdelez left a comment

Looks good to me! One thing to note is that this allows for a few math symbols (÷, ×). Not sure if it's a big issue though.

Loading

@flavens
Copy link
Collaborator Author

@flavens flavens commented Jan 20, 2021

Looks good to me! One thing to note is that this allows for a few math symbols (÷, ×). Not sure if it's a big issue though.

I do not think so. I am not sure these symbols will ever be used in labels.

Loading

@flavens flavens merged commit 8a2654b into main Jan 20, 2021
4 checks passed
Loading
@flavens flavens deleted the wip/dsp-1241-aalow-accented-character branch Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants