Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project landing page): add copy to clipboard functionality (DSP-1248) #368

Merged
merged 7 commits into from Jan 21, 2021

Conversation

@waychal
Copy link
Contributor

@waychal waychal commented Jan 21, 2021

resolves DSP-1248

adds copy to clipboard functionality for citation link, persistent identifier and license using Angular CDK clipboard module.

Copy link
Contributor

@mpro7 mpro7 left a comment

It seems good, but before you merge:

  1. Have a look on my late comments from last PR.
  2. DSP-1284 doesn't exists.
  3. Don't put space between PR title type and scope feat(): instead of feat ():.
  4. Creating branch start with wip/ prefix, so wip/dsp-xxx instead of just dsp-xxx.

Loading

@waychal waychal changed the title feat (project landing page): add copy to clipboard functionality (DSP-1284) feat (project landing page): add copy to clipboard functionality (DSP-1248) Jan 21, 2021
@waychal waychal changed the title feat (project landing page): add copy to clipboard functionality (DSP-1248) feat(project landing page): add copy to clipboard functionality (DSP-1248) Jan 21, 2021
@waychal
Copy link
Contributor Author

@waychal waychal commented Jan 21, 2021

@mpro7

  1. Have a look on my late comments from last PR.

I have updated this PR for your comments from another PR.

  1. DSP-1284 doesn't exists.

Thanks, I have corrected it in PR title and description.

  1. Don't put space between PR title type and scope feat(): instead of feat ():.

Done.

  1. Creating branch start with wip/ prefix, so wip/dsp-xxx instead of just dsp-xxx.

Normally when I create PR they are no longer work in progress (wip). Hence I do not add wip/ in branch name.
If I still have to use the prefix wip/ for branch name even if it is ready for review, let me know and I will do it from next time. For this one, I will keep it as it is.

Loading

@waychal waychal requested a review from mpro7 Jan 21, 2021
mpro7
mpro7 approved these changes Jan 21, 2021
@mpro7
Copy link
Contributor

@mpro7 mpro7 commented Jan 21, 2021

@mpro7

  1. Have a look on my late comments from last PR.

I have updated this PR for your comments from another PR.

  1. DSP-1284 doesn't exists.

Thanks, I have corrected it in PR title and description.

  1. Don't put space between PR title type and scope feat(): instead of feat ():.

Done.

  1. Creating branch start with wip/ prefix, so wip/dsp-xxx instead of just dsp-xxx.

Normally when I create PR they are no longer work in progress (wip). Hence I do not add wip/ in branch name.
If I still have to use the prefix wip/ for branch name even if it is ready for review, let me know and I will do it from next time. For this one, I will keep it as it is.

Thanks!
This what we have in our contribution guideline and I found it useful while working with git on terminal :).

Loading

@waychal waychal merged commit 17bf71c into main Jan 21, 2021
4 checks passed
Loading
@waychal waychal deleted the dsp-1284-copy-to-clipboard branch Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants