Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app+main)!: comment out the search and everything related to resources (DSP-1291) #371

Merged
merged 3 commits into from Jan 28, 2021

Conversation

flavens
Copy link
Contributor

@flavens flavens commented Jan 27, 2021

resolves DSP-1291

@flavens flavens added the refactor Refactor or redesign label Jan 27, 2021
@flavens flavens self-assigned this Jan 27, 2021
@flavens flavens requested a review from kilchenmann Jan 27, 2021
</dsp-search-panel>
<!-- advanced and expert search (in desktop and tablet version) -->
</dsp-search-panel> -->
<!-- to keep? > advanced and expert search (in desktop and tablet version) -->
Copy link
Contributor

@kilchenmann kilchenmann Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"to keep?" --> good point. I think we can delete it. It could be done in a separate refactoring task

@flavens
Copy link
Contributor Author

flavens commented Jan 27, 2021

@kilchenmann about the 2 PRs, should we merge them into main or in a new branch, e.g. dsp-admin?

@kilchenmann
Copy link
Contributor

kilchenmann commented Jan 27, 2021

@kilchenmann about the 2 PRs, should we merge them into main or in a new branch, e.g. dsp-admin?

This is the question. But how could we do a release and a build from this specific branch?

@flavens flavens requested a review from kilchenmann Jan 27, 2021
@flavens
Copy link
Contributor Author

flavens commented Jan 27, 2021

@kilchenmann could you check the changes in the readme file? done in 52e90f2

README.md Outdated
@@ -1,18 +1,18 @@
# DSP APP &mdash; Generic user interface of DaSCH Service Platform
# DSP-ADMIN &mdash; Admin user interface of DaSCH Service Platform
Copy link
Contributor

@kilchenmann kilchenmann Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be confusing when the repo's name is dsp-app but the title is dsp-admin...

@kilchenmann
Copy link
Contributor

kilchenmann commented Jan 28, 2021

@flavens wouldn't it be better to mark this PR as breaking change? Because we have significantly reduced the functionality of the app. In this case we will get a new version (4.0.0) and we know, that this version is the dsp-admin version only.

@kilchenmann kilchenmann changed the title refactor(app+main): comment out the search and everything related to resources (DSP-1291) refactor(app+main)!: comment out the search and everything related to resources (DSP-1291) Jan 28, 2021
@kilchenmann kilchenmann added the breaking Breaking Changes label Jan 28, 2021
@flavens flavens requested a review from kilchenmann Jan 28, 2021
@flavens flavens merged commit 50b1309 into main Jan 28, 2021
@flavens flavens deleted the wip/dsp-1291-search-commented-out branch Jan 28, 2021
@daschbot daschbot mentioned this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants