Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): update cardinality in resource class (DSP-1266) #377

Merged
merged 22 commits into from Feb 12, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Feb 5, 2021

resolves DSP-1266

It works with new created ontologies. Most of the test ontologies doesn't have a lastModificationDate and they can't be edited.
Here are two screen records about "How to update cardinality":

update-res-class-card-interview.mp4
create-and-update-res-class-photo.mp4

The wording will be done in a separate task.

@kilchenmann kilchenmann self-assigned this Feb 9, 2021
@kilchenmann kilchenmann added the enhancement New feature or request label Feb 9, 2021
@kilchenmann kilchenmann requested review from flavens and mdelez Feb 10, 2021
Copy link
Contributor

@flavens flavens left a comment

some tiny things

@@ -1,6 +1,7 @@
<div *ngIf="projectAdmin" class="desktop-only">

<p class="note warning center">This is a first version of the ontology editor. Some features may not work as intended.</p>
<p class="note warning center">This is a first version of the ontology editor. Some features may not work as
Copy link
Contributor

@flavens flavens Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we stick to "data model" instead of "ontology editor"?

Copy link
Contributor Author

@kilchenmann kilchenmann Feb 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 4df6c48

@@ -164,8 +178,9 @@ export class PropertyFormComponent implements OnInit {
* @returns Filtered list of options
*/
filter(list: AutocompleteItem[], label: string) {
console.log(list)
Copy link
Contributor

@flavens flavens Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this console.log must be removed

Copy link
Contributor Author

@kilchenmann kilchenmann Feb 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in d74a77d

this.properties.setControl
resourceClass.properties.forEach(prop => {
this.properties[i] = new FormControl(prop);
// this.properties[i].setValue(prop);
Copy link
Contributor

@flavens flavens Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep these commented lines?

Copy link
Contributor Author

@kilchenmann kilchenmann Feb 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in de4ac1f

@kilchenmann kilchenmann requested a review from flavens Feb 12, 2021
@kilchenmann kilchenmann requested a review from subotic Feb 12, 2021
@kilchenmann kilchenmann merged commit 5a766c1 into main Feb 12, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1266-edit-cardinality branch Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants