Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list-editor): add deletion functionality (DSP-1334) #378

Merged
merged 10 commits into from Feb 16, 2021

Conversation

@mdelez
Copy link
Contributor

@mdelez mdelez commented Feb 9, 2021

resolves DSP-1334

@mdelez mdelez self-assigned this Feb 9, 2021
@mdelez mdelez requested a review from flavens Feb 10, 2021
@mdelez
Copy link
Contributor Author

@mdelez mdelez commented Feb 11, 2021

@flavens this PR actually only deals with deleting a child node and not a root node (the entire list itself). Do you think I should also do that in this PR or in a separate one?

Loading

@flavens
Copy link
Collaborator

@flavens flavens commented Feb 11, 2021

@flavens this PR actually only deals with deleting a child node and not a root node (the entire list itself). Do you think I should also do that in this PR or in a separate one?

You can do it in a separate one.

Loading

@flavens
Copy link
Collaborator

@flavens flavens commented Feb 11, 2021

@mdelez so we cannot delete the root node but also the last or only child node, right? is it the correct current behaviour?

Loading

@mdelez
Copy link
Contributor Author

@mdelez mdelez commented Feb 15, 2021

@mdelez so we cannot delete the root node but also the last or only child node, right? is it the correct current behaviour?

You should be able to delete the last or only child node as of DSP-API 13.3.1

Loading

@mdelez mdelez merged commit 34c74a6 into main Feb 16, 2021
6 checks passed
Loading
@mdelez mdelez deleted the wip/DSP-1334-delete-list-node branch Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants