Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list-editor): reposition a child node amongst its siblings (DSP-1340) #388

Merged
merged 7 commits into from Feb 19, 2021

Conversation

@mdelez
Copy link
Contributor

@mdelez mdelez commented Feb 17, 2021

resolves DSP-1340

@mdelez mdelez self-assigned this Feb 17, 2021
@mdelez
Copy link
Contributor Author

@mdelez mdelez commented Feb 18, 2021

I discovered I was using quite an old version of npm which was creating conflicting package-lock.json files. Should be fixed now.

Loading

@mdelez mdelez requested a review from kilchenmann Feb 18, 2021
@mdelez
Copy link
Contributor Author

@mdelez mdelez commented Feb 18, 2021

@kilchenmann This PR adds these two buttons to the "action bubble" and the up and down arrows hide if the node cannot move in that direction. I did not implement it as drag and drop for version 1. Explained in more detail here.
Screen Shot 2021-02-18 at 13 35 26

Loading

@mdelez mdelez requested a review from waychal Feb 19, 2021
Copy link
Contributor

@waychal waychal left a comment

Everything else look ok to me.

Loading

</button>
<button mat-button
*ngIf="!lastPosition"
class="reposition down"
Copy link
Contributor

@waychal waychal Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the conventions written here class should be at the end.

Loading

Copy link
Contributor Author

@mdelez mdelez Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 4f8909d

Loading

@mdelez mdelez requested a review from waychal Feb 19, 2021
@mdelez mdelez merged commit 0a9be0e into main Feb 19, 2021
6 checks passed
Loading
@mdelez mdelez deleted the wip/DSP-1340-reposition-list-node branch Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants