Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ontology): bug fix in list property (DSP-1368) #390

Merged
merged 5 commits into from Feb 23, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Feb 22, 2021

resolves DSP-1368

@kilchenmann kilchenmann requested a review from mdelez Feb 22, 2021
@kilchenmann kilchenmann self-assigned this Feb 22, 2021
@kilchenmann kilchenmann requested a review from flavens Feb 22, 2021
Copy link
Collaborator

@flavens flavens left a comment

LGTM except the fdescribe (see my comment) - so let's see if all the tests still pass!!

Loading


}

fdescribe('PropertyInfoComponent', () => {
Copy link
Collaborator

@flavens flavens Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you left a fdescribe

Loading

Copy link
Collaborator Author

@kilchenmann kilchenmann Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Oops, I forgot to remove it. → done in 21eea72

Loading

@kilchenmann kilchenmann merged commit 2fb448e into main Feb 23, 2021
6 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1368-property-list-label branch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants