Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): separate list of ontology properties (DSP-1364) #391

Merged
merged 10 commits into from Feb 25, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Feb 22, 2021

resolves DSP-1364

This is a first version of a separate list of properties. In another task we will add a filter and sort button.

@kilchenmann kilchenmann self-assigned this Feb 22, 2021
@kilchenmann kilchenmann marked this pull request as draft Feb 22, 2021
@kilchenmann kilchenmann changed the title feat(ontology): separate list of ontology properties incl. edit property form (DSP-1364) feat(ontology): separate list of ontology properties (DSP-1371) Feb 23, 2021
@kilchenmann kilchenmann changed the title feat(ontology): separate list of ontology properties (DSP-1371) feat(ontology): separate list of ontology properties (DSP-1364) Feb 23, 2021
@kilchenmann kilchenmann requested review from mdelez and flavens Feb 23, 2021
@kilchenmann kilchenmann marked this pull request as ready for review Feb 23, 2021
.ontology-editor-canvas {
min-height: calc(100vh - #{$sub-header-height} - #{$header-height} - #{$tab-bar-margin} - 100px);
// background: $primary_200;
Copy link
Collaborator

@flavens flavens Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when there are unused css classes, we should clean them up or add a comment (remark valid for all the scss files)

Loading

Copy link
Collaborator Author

@kilchenmann kilchenmann Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the css classes are not defined in the scss file, that's true. But they are needed for the tests.

Or are you talking about the commented css property here? I can clean them up...

Loading

Copy link
Collaborator Author

@kilchenmann kilchenmann Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in ac7c3cf

Loading

@mdelez
Copy link
Contributor

@mdelez mdelez commented Feb 24, 2021

Screen Shot 2021-02-24 at 12 23 37

The numbering seems to be a little messed up 🤔

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Feb 24, 2021

The numbering seems to be a little messed up 🤔

Yes I know. I'm using the number from gui order. This Gui order is defined in the ontology; it's part of the res class cardinality. In case of missing or doubled numbers it's a mistake in the ontology. The test data are not well done.

Loading

mdelez
mdelez approved these changes Feb 25, 2021
Copy link
Contributor

@mdelez mdelez left a comment

I would stress that we need to have some unit tests for the ontology component but I don't think this is the PR for that so I'll approve this one :)

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Feb 25, 2021

I would stress that we need to have some unit tests for the ontology component but I don't think this is the PR for that so I'll approve this one :)

I'm working on it 😉

Loading

@kilchenmann kilchenmann merged commit 0f94df6 into main Feb 25, 2021
6 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1364-properties-list branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants