Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): migrate tslint to eslint (DSP-1372) #394

Merged
merged 62 commits into from Mar 4, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Feb 24, 2021

resolves DSP-1372

The most important file that has to be reviewed in this PR is the .eslintrc.js (eslint config file).

kilchenmann added 25 commits Feb 24, 2021
Loading
.eslintrc.js Show resolved Hide resolved
Loading
@kilchenmann kilchenmann requested a review from tobiasschweizer Mar 2, 2021
.eslintrc.js Show resolved Hide resolved
Loading
.eslintrc.js Outdated Show resolved Hide resolved
Loading
@kilchenmann kilchenmann requested a review from flavens Mar 2, 2021
flavens
flavens approved these changes Mar 2, 2021
@kilchenmann kilchenmann requested a review from mpro7 Mar 3, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Mar 4, 2021

For the reviewers: I just added new rules about spaces in objects which is defined here:
https://docs.google.com/document/d/1SIVMxoV0N8xYqhVk_0hhuqSuUF47D1YYrDESqdmipfM/edit#heading=h.awf6ef8h98ze

Loading

@kilchenmann kilchenmann merged commit 6ffc3b6 into main Mar 4, 2021
6 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1372-migrate-tslint-to-eslint branch Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants