Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list-editor): insert a child node at a specific position (DSP-1301) #395

Merged
merged 9 commits into from Feb 26, 2021

Conversation

@mdelez
Copy link
Contributor

@mdelez mdelez commented Feb 24, 2021

resolves DSP-1301

@mdelez mdelez self-assigned this Feb 24, 2021
@mdelez
Copy link
Contributor Author

@mdelez mdelez commented Feb 24, 2021

tests won't run on GithubCi until a version of DSP-JS is released with this change dasch-swiss/dsp-js-lib#322

Loading

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Feb 24, 2021

tests won't run on GithubCi until a version of DSP-JS is released with this change dasch-swiss/dsp-js-lib#322

I can do a release of js-lib. The problem is the following: PR #322 is marked as refactor which is ignored by release-please (s. contribution documentation --> "The first three items on this list (fix, feat and type with !) are taken into account for the release notes and have an effect on the version number.") and this is why the github actions didn't create a release PR. We could create a new release manually or waiting for the next merged PR.

Loading

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Feb 25, 2021

@mdelez p.s. I created a user story about the refactor-topic in PRs: DSP-1378

Loading

@mdelez
Copy link
Contributor Author

@mdelez mdelez commented Feb 25, 2021

tests won't run on GithubCi until a version of DSP-JS is released with this change dasch-swiss/dsp-js-lib#322

I can do a release of js-lib. The problem is the following: PR #322 is marked as refactor which is ignored by release-please (s. contribution documentation --> "The first three items on this list (fix, feat and type with !) are taken into account for the release notes and have an effect on the version number.") and this is why the github actions didn't create a release PR. We could create a new release manually or waiting for the next merged PR.

oh cool, thanks for the info! It's not urgent as I can use yalc for the time being until another PR is merged :)

Loading

@mdelez
Copy link
Contributor Author

@mdelez mdelez commented Feb 25, 2021

Also waiting for this change from DSP-JS dasch-swiss/dsp-js-lib#324

Loading

@mdelez mdelez requested review from kilchenmann and flavens Feb 26, 2021
@@ -1,5 +1,5 @@
import { Component, EventEmitter, Inject, Input, OnInit, Output } from '@angular/core';
import { ApiResponseData, ApiResponseError, ChildNodeInfoResponse, KnoraApiConnection, List, ListNodeInfo, ListNodeInfoResponse, StringLiteral, UpdateChildNodeRequest } from '@dasch-swiss/dsp-js';
import { ApiResponseData, ApiResponseError, ChildNodeInfoResponse, CreateChildNodeRequest, KnoraApiConnection, List, ListNodeInfo, ListNodeInfoResponse, StringLiteral, UpdateChildNodeRequest } from '@dasch-swiss/dsp-js';
Copy link
Collaborator

@kilchenmann kilchenmann Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This long line should be aligned

Loading

Copy link
Contributor Author

@mdelez mdelez Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 0b490f3

Loading

@mdelez mdelez merged commit 5107200 into main Feb 26, 2021
6 checks passed
Loading
@mdelez mdelez deleted the wip/DSP-1301-insert-child-node-at-position branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants