Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(project landing page): update metadata typings (DSP-1393) #407

Merged
merged 3 commits into from Mar 4, 2021

Conversation

waychal
Copy link
Contributor

@waychal waychal commented Mar 3, 2021

resolves DSP-1393

@waychal waychal added the refactor Refactor or redesign label Mar 3, 2021
@waychal waychal requested a review from mpro7 Mar 3, 2021
@mpro7 mpro7 changed the title refactor(project landing page): updated metadata typings (DSP-1393) refactor(project landing page): update metadata typings (DSP-1393) Mar 4, 2021
PropertyInfoComponent,
UrlTemplateComponent
Copy link
Collaborator

@mpro7 mpro7 Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have the declarations sorted.

<div *ngIf="templateType == 'string'">
<p *ngFor="let str of urls" class="remove-top-margin"> {{ str }} </p>
</div>
<div *ngIf="templateType == 'IUrl'">
Copy link
Collaborator

@mpro7 mpro7 Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use strict equality operator ===.

@Input() displayLabel ?: boolean = false;

@Input() isPerson ?: boolean = false;
Copy link
Collaborator

@mpro7 mpro7 Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove typings here because of initiation with the primitive values. Also safe operator ? doesn't require space after property name.

@kilchenmann
Copy link
Contributor

kilchenmann commented Mar 4, 2021

@waychal I'm sorry, I was on the wrong PR and updated from main.

@mpro7
Copy link
Collaborator

mpro7 commented Mar 4, 2021

@waychal I'm sorry, I was on the wrong PR and updated from main.

Could you revert that please? It broke the build.

@waychal
Copy link
Contributor Author

waychal commented Mar 4, 2021

@kilchenmann No problem. I will check it. I normally rebase the main branch but merge is also fine.

@kilchenmann
Copy link
Contributor

kilchenmann commented Mar 4, 2021

@kilchenmann No problem. I will check it. I normally rebase the main branch but merge is also fine.

I'll fix it, if it's okay. Just a missing comma in app.module.ts and the build should run again

@waychal
Copy link
Contributor Author

waychal commented Mar 4, 2021

@mpro7 done in 73bfb09

@waychal waychal requested a review from mpro7 Mar 4, 2021
mpro7
mpro7 approved these changes Mar 4, 2021
@waychal waychal merged commit b4f101b into main Mar 4, 2021
6 checks passed
@waychal waychal deleted the wip/dsp-1393-fix-metadata-typings branch Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants