Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migrate to angular10): changes (DSP-1415) #412

Merged
merged 7 commits into from Apr 8, 2021

Conversation

@waychal
Copy link
Contributor

@waychal waychal commented Mar 23, 2021

resolves DSP-1415

@waychal waychal added the chore label Mar 23, 2021
@waychal waychal requested a review from tobiasschweizer Mar 23, 2021
@waychal waychal changed the title Wip/dsp 1415 migrate to angular10 (DSP-1415) chore(migrate to angular10): changes (DSP-1415) Mar 23, 2021
"jdnconvertiblecalendar": "^0.0.5",
"jdnconvertiblecalendardateadapter": "^0.0.13",
"jdnconvertiblecalendar": "^0.0.6",
"jdnconvertiblecalendardateadapter": "^0.0.15",

This comment has been hidden.

Loading

Copy link
Contributor

@tobiasschweizer tobiasschweizer Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, 0.0.15 is fine

Loading

@waychal waychal force-pushed the wip/DSP-1415-migrate-to-angular10 branch from 3e206c2 to 30f4899 Mar 23, 2021
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

I spotted a few warnings about modules built with commonJS:

WARNING in dsp-app/node_modules/@dasch-swiss/dsp-js/test/data/api/admin/mock-users.js depends on 'json2typescript'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'ngraph.graph'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'ngraph.forcelayout'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'tinycolor2'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Maybe for some of these packages there is a newer version that could be used instead?

Loading

@waychal
Copy link
Contributor Author

@waychal waychal commented Mar 23, 2021

I spotted a few warnings about modules built with commonJS:

WARNING in dsp-app/node_modules/@dasch-swiss/dsp-js/test/data/api/admin/mock-users.js depends on 'json2typescript'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'ngraph.graph'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'ngraph.forcelayout'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'tinycolor2'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Maybe for some of these packages there is a newer version that could be used instead?

I will check it.

Loading

@tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Mar 23, 2021

I spotted a few warnings about modules built with commonJS:

WARNING in dsp-app/node_modules/@dasch-swiss/dsp-js/test/data/api/admin/mock-users.js depends on 'json2typescript'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'ngraph.graph'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'ngraph.forcelayout'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'tinycolor2'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Maybe for some of these packages there is a newer version that could be used instead?

I will check it.

otherwise these warnings can be ignored, see https://stackoverflow.com/questions/62589229/angular-10-upgrade-fix-commonjs-or-amd-dependencies-can-cause-optimization-bai

Loading

@waychal waychal requested a review from tobiasschweizer Apr 7, 2021
@waychal
Copy link
Contributor Author

@waychal waychal commented Apr 7, 2021

@tobiasschweizer I have removed the warnings for CommonJS or AMD dependencies. Can you please review the PR again?

Loading

@waychal waychal merged commit cec564d into main Apr 8, 2021
6 checks passed
Loading
@waychal waychal deleted the wip/DSP-1415-migrate-to-angular10 branch Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants