Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compiler): enable strict template (DSP-1403) #432

Merged
merged 8 commits into from May 10, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Apr 27, 2021

resolves DSP-1403

Additional I tried to keep "projectCode" consistent

@kilchenmann kilchenmann self-assigned this Apr 27, 2021
@kilchenmann kilchenmann added the refactor Refactor or redesign label Apr 27, 2021
kilchenmann added 6 commits Apr 27, 2021
Test on gh-ci failed because of this:
Chrome Headless 90.0.4430.93 (Linux x86_64) PropertyFormComponent should update labels when the value changes FAILED
69
	Expected ' Update
70

71

72
	' to equal ' Update '.
@kilchenmann kilchenmann requested a review from flavens May 9, 2021
Copy link
Contributor

@flavens flavens left a comment

lgtm

@kilchenmann kilchenmann merged commit 583a338 into main May 10, 2021
6 checks passed
@kilchenmann kilchenmann deleted the wip/dsp-1403-enable-strict-template branch May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants