Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DMP): own resource viewer (DSP-1586) #434

Merged
merged 23 commits into from May 7, 2021
Merged

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented May 3, 2021

resolves DSP-1586

In this PR we implemented the resource compound object viewer. To resolve it we had to move some components from DSP-UI into DSP-APP:

  • property-view.component (new: resource-properties.component)
  • property-toolbar.component (new: resource-toolbar.component)
  • still-image.component
  • resource-view.component (contains some parts from dhlab-basel/beol)
@kilchenmann kilchenmann self-assigned this May 3, 2021
@kilchenmann kilchenmann marked this pull request as draft May 3, 2021
@kilchenmann kilchenmann requested a review from flavens May 6, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented May 6, 2021

Screen.Recording.2021-05-06.at.23.18.56.mov

Loading

@kilchenmann kilchenmann marked this pull request as ready for review May 6, 2021
@kilchenmann kilchenmann requested review from mdelez and subotic May 7, 2021
@mdelez
Copy link
Contributor

@mdelez mdelez commented May 7, 2021

Editing and saving an existing value isn't working correctly for me. I get a 404 for some reason but if I refresh the page, I can see my changes.

Screen Shot 2021-05-07 at 12 14 57

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented May 7, 2021

Editing and saving an existing value isn't working correctly for me. I get a 404 for some reason but if I refresh the page, I can see my changes.

Screen Shot 2021-05-07 at 12 14 57

Yes you're right. There's something weird. You're the expert in the value components 😉 any idea? I will also have a look at it...

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented May 7, 2021

Editing and saving an existing value isn't working correctly for me. I get a 404 for some reason but if I refresh the page, I can see my changes.

@mdelez Which version of the API are you using? I updated to the latest version (v13.7.0) and it works perfect

Loading

@kilchenmann kilchenmann requested a review from mdelez May 7, 2021
@mdelez
Copy link
Contributor

@mdelez mdelez commented May 7, 2021

Editing and saving an existing value isn't working correctly for me. I get a 404 for some reason but if I refresh the page, I can see my changes.

@mdelez Which version of the API are you using? I updated to the latest version (v13.7.0) and it works perfect

The 404 comes from me not having the images in my test data 😅

Loading

mdelez
mdelez approved these changes May 7, 2021
subotic
subotic approved these changes May 7, 2021
@kilchenmann kilchenmann merged commit 35bd7b3 into main May 7, 2021
6 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1586-compound-viewer branch May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants