Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): new method to change gui order (DSP-1567/DSP-1646) #440

Merged
merged 17 commits into from May 21, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented May 10, 2021

resolves DSP-1567 and DSP-1646

This PR contains a quick solution to solve our update-gui-order-issue in case if the property is already in use (DSP-1546). Since we have two DSP-API routes to change either the cardinality or the gui-order, we should also split those tasks into different views in DSP-APP. This step will take more time and we have to fix the current state on our servers now. The current solution is as follow: We send to request to DSP-API: one to update the gui-order and one to update the cardinalities. The second request will throw always an error if the property is in use and has already data values. There's another workaround for that issue, but it's not yet published in DSP-API. So for now, I suggest to keep this "ugly" solution.

@kilchenmann kilchenmann marked this pull request as draft May 10, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented May 10, 2021

This PR needs a new version of DSP-JS with changes from PR #343

Loading

@kilchenmann kilchenmann marked this pull request as ready for review May 11, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented May 17, 2021

@flavens You'll need at least DSP-API v13.7.0 (with the new route to update the gui-order https://github.com/dasch-swiss/dsp-api/releases/tag/v13.7.0)

It's hard to say what was going wrong here. What's the message in the API error response of:

Screen Shot 2021-05-17 at 14 06 26

Loading

@flavens
Copy link
Collaborator

@flavens flavens commented May 18, 2021

@flavens You'll need at least DSP-API v13.7.0 (with the new route to update the gui-order https://github.com/dasch-swiss/dsp-api/releases/tag/v13.7.0)

It's hard to say what was going wrong here. What's the message in the API error response of:

With the anything ontology, the API response has been quoted in my message from the network tab. There is no more details in the console.

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented May 18, 2021

@flavens You'll need at least DSP-API v13.7.0 (with the new route to update the gui-order https://github.com/dasch-swiss/dsp-api/releases/tag/v13.7.0)
It's hard to say what was going wrong here. What's the message in the API error response of:

With the anything ontology, the API response has been quoted in my message from the network tab. There is no more details in the console.

Not in the console, but in the network...

But I will also check-out this branch again. At the moment I'm working with the region-annotation-branch.

@flavens Got it! I'll try to understand the issue here...

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented May 19, 2021

There are several issues and I couldn't find a quick solution to keep the current implementation (s. my comment on Youtrack DSP-1567). I will separate the two requests now.

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented May 20, 2021

As mentioned in one of the Youtrack issues, it was not possible to keep the current setup to change the gui-order of properties in a resource class. So I implemented a new way to change the gui-order (DSP-1646):

Screen.Recording.2021-05-20.at.12.01.15.mov

Loading

@kilchenmann kilchenmann changed the title fix(ontology): new method to change gui order (DSP-1567) fix(ontology): new method to change gui order (DSP-1567/DSP-1646) May 20, 2021
@kilchenmann kilchenmann requested a review from flavens May 20, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented May 20, 2021

@mdelez @waychal @lrosenth now it should be ready for the review

Loading

@kilchenmann kilchenmann changed the title fix(ontology): new method to change gui order (DSP-1567/DSP-1646) feat(ontology): new method to change gui order (DSP-1567/DSP-1646) May 21, 2021
@kilchenmann kilchenmann dismissed flavens’s stale review May 21, 2021

I have to dismiss this review, because the PR contains now a new implementation of the gui-order update process

mdelez
mdelez approved these changes May 21, 2021
@kilchenmann kilchenmann merged commit dfd0ce0 into main May 21, 2021
8 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1567-update-gui-order branch May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants