Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable progress bar if search results are empty (DSP-1575) #442

Merged
merged 6 commits into from May 26, 2021

Conversation

@waychal
Copy link
Contributor

@waychal waychal commented May 19, 2021

resolves DSP-1575

@flavens When page is refreshed with search string in the url, it displays search results on the page but same search string is not displayed in the search input box.

This bug requires changes in dsp-ui-lib and can be fixed in separate PR.

Screenshot 2021-05-19 at 13 25 50

@waychal waychal added the bug label May 19, 2021
@waychal waychal requested a review from flavens May 19, 2021
Copy link
Collaborator

@flavens flavens left a comment

It looks good for the fulltext search - just a little css position to change. However, I have tried the advanced search and here, nothing: no result, no message, no console log.. It may not be related but it should be investigated in case the display problem comes from this PR.

Loading


<!-- In case of 0 result -->
<div class="no-results" *ngIf="!loading && numberOfAllResults === 0">
<p>Your search <span *ngIf="searchMode === 'fulltext'">- <strong> {{searchQuery}}</strong> -</span> did not match any documents.</p>
Copy link
Collaborator

@flavens flavens May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this message should be centered in the middle of the page instead of being displayed on the left side

Loading

Copy link
Contributor Author

@waychal waychal May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Loading

@waychal
Copy link
Contributor Author

@waychal waychal commented May 25, 2021

It looks good for the fulltext search - just a little css position to change. However, I have tried the advanced search and here, nothing: no result, no message, no console log.. It may not be related but it should be investigated in case the display problem comes from this PR.

I have fixed the issue in commit 7d5443e

Loading

@waychal waychal requested a review from flavens May 25, 2021
Copy link
Collaborator

@flavens flavens left a comment

When I test the advanced search, I get the results as before but the loading spiner is running whereas you have set it to false...

Screen.Recording.2021-05-25.at.14.48.40.mov

Loading

@waychal waychal requested a review from flavens May 25, 2021
@waychal waychal force-pushed the wip/DSP-1575-empty-search-results-issue branch from be1814f to 2c7130f May 26, 2021
@waychal waychal merged commit 8c67d60 into main May 26, 2021
8 checks passed
Loading
@waychal waychal deleted the wip/DSP-1575-empty-search-results-issue branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants