Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation about contribution (DSP-1657) #449

Merged
merged 5 commits into from May 25, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented May 25, 2021

resolves DSP-1657

@kilchenmann kilchenmann requested review from flavens and gautschr May 25, 2021
@kilchenmann kilchenmann self-assigned this May 25, 2021
@kilchenmann kilchenmann added the documentation Add or update doc files label May 25, 2021
Copy link
Contributor

@flavens flavens left a comment

It looks good.
Just one comment about the link to the DSP-API doc in README.md, we end up on a 404 page... and it is not the best...

@kilchenmann
Copy link
Contributor Author

kilchenmann commented May 25, 2021

It looks good.
Just one comment about the link to the DSP-API doc in README.md, we end up on a 404 page... and it is not the best...

Ok, I see. This is another task, but I can fix it here. Yes, there's still the open question how we publish all the documentation at one place (DSP-1066). Since we cleaned up the dsp-docs, but we did not resolved the monorepo-documentation build, we have dead links which is really really bad.

@kilchenmann kilchenmann merged commit c25280d into main May 25, 2021
8 checks passed
@kilchenmann kilchenmann deleted the wip/dsp-1657-update-documentation branch May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Add or update doc files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants