Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(resource): improve list of properties in resource viewer (DSP-1663) #453

Merged
merged 10 commits into from May 26, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented May 26, 2021

resolves DSP-1663

In this PR I combined/copied the two components ResourceToolbarComponent and ResourcePropertiesComponent into one new component. It was an old implementation from DSP-UI but this use case is no longer needed. With the combination I tried also to simplify the html template and the component parameters. The toggle button to show or hide empty properties works better because it's directly part of the new PropertiesComponent. Best way to test the button:

Additional I resolved the issue mentioned in the third item of #445 (review)

@kilchenmann kilchenmann self-assigned this May 26, 2021
@kilchenmann kilchenmann marked this pull request as draft May 26, 2021
@kilchenmann kilchenmann changed the title feat(resource): improve "show all properties" toggle and project info refactor(resource): improve list of properties in resource viewer May 26, 2021
@kilchenmann kilchenmann marked this pull request as ready for review May 26, 2021
@kilchenmann kilchenmann requested review from flavens, mdelez and waychal May 26, 2021
@kilchenmann kilchenmann requested a review from gautschr May 26, 2021
Copy link
Contributor

@waychal waychal left a comment

I have checked the functionality and it works fine.

Loading

import { StillImageComponent } from './workspace/resource/representation/still-image/still-image.component';
import { PropertiesComponent } from './workspace/resource/properties/properties.component';
Copy link
Contributor

@waychal waychal May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please sort the imports?

Loading

Copy link
Collaborator Author

@kilchenmann kilchenmann May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 17058ef

Loading

Copy link
Contributor

@gautschr gautschr left a comment

works perfectly - thank you!

Loading

@kilchenmann kilchenmann merged commit 49d9b7f into main May 26, 2021
8 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1663-show-all-props-toggle branch May 26, 2021
@kilchenmann kilchenmann changed the title refactor(resource): improve list of properties in resource viewer refactor(resource): improve list of properties in resource viewer (DSP-1663) May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants