Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upload)!: add upload form for still images (DSP-1761) #472

Merged
merged 10 commits into from Jun 28, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jun 23, 2021

resolves DSP-1761

In this PR I copied the upload file component from DSP-UI directly to DSP-APP.
Additional I fixed an issue in the resource instance form in the project selection. A user should be able to select only the active projects (where s/he's member of) and the Knora and the System project should also not be displayed.

This PR contains a breaking change: The config file needs now the URL of our iiif service (sipi).

@kilchenmann kilchenmann self-assigned this Jun 23, 2021
@kilchenmann kilchenmann added enhancement New feature or request breaking Breaking Changes labels Jun 23, 2021
@kilchenmann kilchenmann marked this pull request as draft Jun 25, 2021
@kilchenmann kilchenmann requested a review from subotic Jun 28, 2021
@kilchenmann kilchenmann marked this pull request as ready for review Jun 28, 2021
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jun 28, 2021

Screen.Recording.2021-06-28.at.15.40.57.mov

@kilchenmann kilchenmann merged commit 2f314a2 into main Jun 28, 2021
8 checks passed
@kilchenmann kilchenmann deleted the wip/dsp-1761-prepare-upload branch Jun 28, 2021
@daschbot daschbot mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants