Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): display description for default and existing props (DSP-1154) #475

Merged
merged 8 commits into from Jun 30, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Jun 29, 2021

resolves DSP-1154

@kilchenmann kilchenmann requested review from mdelez and gautschr Jun 29, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Jun 29, 2021

The description from the default properties will be displayed as tooltipp:

Screen Shot 2021-06-29 at 14 58 42

@mdelez could you check the english sentences? Thanks

Loading

@gautschr
Copy link
Contributor

@gautschr gautschr commented Jun 29, 2021

I suggest for "Text":
"Short text such as" instead of "Small text like"

A question concerning Date/Time: The inclusion of the new GUI element which allows for a proper display of dates with lower precision than one day - is this another PR?

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Jun 29, 2021

I suggest for "Text":
"Short text such as" instead of "Small text like"

I will update as suggested. → done in 6fb9746

A question concerning Date/Time: The inclusion of the new GUI element which allows for a proper display of dates with lower precision than one day - is this another PR?

The new gui element for dates should already be implemented. So yes, how should the description look like?

Loading

Loading
Loading
@@ -218,18 +235,11 @@ export class DefaultProperties {
{
icon: 'palette',
label: 'Color',
description: 'A simple color value',
Copy link
Contributor

@mdelez mdelez Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably clarify that this is a hexadecimal value. Ex: "A hexadecimal color value"

Loading

Copy link
Collaborator Author

@kilchenmann kilchenmann Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if everyone understands the term "hexadecimal". Apart from that, in the GUI we have the color picker only and the hexadecimal value itself is not displayed anymore (s. DSP-1667)

Loading

Copy link
Contributor

@mdelez mdelez Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair :)

Loading

Loading
Loading
}
// {
Copy link
Contributor

@mdelez mdelez Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this code still needed?

Loading

Copy link
Collaborator Author

@kilchenmann kilchenmann Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we have to reactivate it one day!?

Loading

@kilchenmann kilchenmann requested a review from mdelez Jun 30, 2021
mdelez
mdelez approved these changes Jun 30, 2021
@kilchenmann kilchenmann merged commit 8be7e55 into main Jun 30, 2021
8 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1154-default-props branch Jun 30, 2021
@gautschr
Copy link
Contributor

@gautschr gautschr commented Jul 1, 2021

We need a kind of dd/mm/yyyy BCE/CE icon and for the short description I suggest "dd/mm/yyyy format; for historical dates"

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants