Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): upload audio (DSP-1799) #486

Merged
merged 9 commits into from Jul 26, 2021
Merged

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Jul 19, 2021

resolves DSP-1799

Upload audio file works, but we do not have an audio player yet; this will be implemented in the next iteration. It's the old chicken or the egg dilemma. It means for the reviewers, when you want to test it (even it's a code review only), you have to check the API answer in the developer tools or you should find the file in the dsp-api/sipi/images/[project]/-folder

@kilchenmann kilchenmann requested a review from mdelez Jul 20, 2021
@kilchenmann kilchenmann requested a review from Vijeinath Jul 22, 2021
Copy link
Contributor

@mdelez mdelez left a comment

This works well if I use it exactly how I'm supposed to but I noticed that if I upload a file (via drag and drop) and then delete it and click save, it scrolls to the upload section. If I then upload a file and click save I get this error and no matter what I do I cannot save the resource:
Screen Shot 2021-07-22 at 10 50 26

Another thing I noticed is that if I edit my data model, the changes aren't reflected immediately if I click on the plus button on the top right to create a new resource. But maybe this could be a separate PR.
Screen Shot 2021-07-22 at 10 44 23

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Jul 22, 2021

This works well if I use it exactly how I'm supposed to but I noticed that if I upload a file (via drag and drop) and then delete it and click save, it scrolls to the upload section. If I then upload a file and click save I get this error and no matter what I do I cannot save the resource:

--> I'm able to reproduce the issue, but I don't get the error message. But I figured out, that the submit button is not disabled anymore in case the form is wrong / has missing values in required fields

Another thing I noticed is that if I edit my data model, the changes aren't reflected immediately if I click on the plus button on the top right to create a new resource. But maybe this could be a separate PR.

--> this is indeed a separate task. Would you like to write a bug report in youtrack and assign to me?

Loading

@mdelez
Copy link
Contributor

@mdelez mdelez commented Jul 22, 2021

This works well if I use it exactly how I'm supposed to but I noticed that if I upload a file (via drag and drop) and then delete it and click save, it scrolls to the upload section. If I then upload a file and click save I get this error and no matter what I do I cannot save the resource:

--> I'm able to reproduce the issue, but I don't get the error message. But I figured out, that the submit button is not disabled anymore in case the form is wrong / has missing values in required fields

Another thing I noticed is that if I edit my data model, the changes aren't reflected immediately if I click on the plus button on the top right to create a new resource. But maybe this could be a separate PR.

--> this is indeed a separate task. Would you like to write a bug report in youtrack and assign to me?

  1. Yes, ideally the save button should be disabled if the form is invalid but I wasn't sure if this was set up already
  2. Bug report opened -> DSP-1810

Loading

Copy link
Contributor

@Vijeinath Vijeinath left a comment

I'm happy with it

Loading

Loading
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Jul 22, 2021

  1. Yes, ideally the save button should be disabled if the form is invalid but I wasn't sure if this was set up already

@mdelez it should be resolved now

Loading

@kilchenmann kilchenmann requested a review from mdelez Jul 22, 2021
mdelez
mdelez approved these changes Jul 26, 2021
Copy link
Contributor

@mdelez mdelez left a comment

Save button works appropriately now :)

Loading

@kilchenmann kilchenmann merged commit d865df5 into main Jul 26, 2021
8 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1799-upload-audio branch Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants