Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): update resource's label (DSP-1801) #492

Merged
merged 2 commits into from Aug 2, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Jul 27, 2021

resolves DSP-1801

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Jul 27, 2021

Loading

@kilchenmann kilchenmann self-assigned this Jul 27, 2021
@kilchenmann kilchenmann requested a review from mdelez Jul 27, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Jul 27, 2021

@mdelez what should we do with the two issues mentioned in previous comment? In second case it needs an update of the API or should I do a second request to get the necessary information? Any suggestions?

Loading

@kilchenmann kilchenmann marked this pull request as draft Jul 30, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Jul 30, 2021

This is the first iteration. It has to be improved as soon as DSP-API resolved the "update metadata" response. At the moment it's not possible to edit the label twice without refreshing the whole page.
For the moment we can't wait for new release of DSP-API because this will be v14.0.0 which contains a lot of breaking changes.

Loading

@kilchenmann kilchenmann marked this pull request as ready for review Jul 30, 2021
@kilchenmann kilchenmann requested review from mdelez and Vijeinath and removed request for mdelez Jul 30, 2021
mdelez
mdelez approved these changes Aug 2, 2021
Copy link
Contributor

@mdelez mdelez left a comment

looks good :)

Loading

@kilchenmann kilchenmann merged commit e2c9867 into main Aug 2, 2021
8 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1801-edit-label branch Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants