Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error handler and fix search results issue (DSP-1826 / DSP-1831) #493

Merged
merged 9 commits into from Aug 2, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Jul 30, 2021

resolves DSP-1831

resolves DSP-1826

@kilchenmann kilchenmann self-assigned this Jul 30, 2021
@kilchenmann kilchenmann marked this pull request as draft Jul 30, 2021
@kilchenmann kilchenmann changed the title Improve error handler and fix search results issue (DSP-1831) Improve error handler and fix search results issue (DSP-1826 / DSP-1831) Jul 30, 2021
@kilchenmann kilchenmann marked this pull request as ready for review Jul 30, 2021
@kilchenmann kilchenmann requested review from Vijeinath and mdelez Jul 30, 2021
@@ -29,11 +28,9 @@ export class ResultsComponent {
searchMode: 'fulltext' | 'gravsearch';

// progress status
loading = true;
loading = false;
Copy link
Contributor

@mdelez mdelez Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still needed? I don't think this variable is used anywhere now.

Loading

Copy link
Collaborator Author

@kilchenmann kilchenmann Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, well seen 👍 no it's not needed anymore.

Removed in ed38403

Loading

@kilchenmann kilchenmann requested a review from mdelez Aug 2, 2021
mdelez
mdelez approved these changes Aug 2, 2021
@kilchenmann kilchenmann merged commit 70a263c into main Aug 2, 2021
8 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1831-error-handler-and-fix-search-results branch Aug 2, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Aug 2, 2021

Oh no, the title was wrong. This PR will not shown in the release notes

Loading

@kilchenmann kilchenmann changed the title Improve error handler and fix search results issue (DSP-1826 / DSP-1831) chore: improve error handler and fix search results issue (DSP-1826 / DSP-1831) Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants