Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(header): clean up code and use notification service after login #498

merged 4 commits into from Aug 11, 2021


Copy link

@kilchenmann kilchenmann commented Aug 10, 2021

This is a quick refactoring of the header component. Incl. the notification service instead the deprecated message component from DSP-UI after successful login. I thought I refactored it already, but it was still the old implementation. This PR fixes it now.

@kilchenmann kilchenmann self-assigned this Aug 10, 2021
@kilchenmann kilchenmann requested a review from mdelez Aug 10, 2021
mdelez approved these changes Aug 11, 2021
@kilchenmann kilchenmann merged commit fb6c368 into main Aug 11, 2021
8 checks passed
@kilchenmann kilchenmann deleted the wip/refactoring branch Aug 11, 2021
@kilchenmann kilchenmann added the refactor Refactor or redesign label Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
refactor Refactor or redesign
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants