Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): delete property from resource class (DSP-1854 / DEV-28) #499

Merged
merged 10 commits into from Oct 19, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Aug 10, 2021

resolves DEV-28 (resp. original task DSP-1854)

should work with latest version of DSP-API (v15.0.2).

@kilchenmann kilchenmann self-assigned this Aug 10, 2021
@kilchenmann kilchenmann marked this pull request as draft Aug 10, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Aug 10, 2021

This PR needs a new version of DSP-API (PR #1869) and DSP-JS (PR #365)

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Oct 13, 2021

This PR needs a new version of DSP-API (PR #1919)

Loading

@kilchenmann kilchenmann marked this pull request as ready for review Oct 19, 2021
@kilchenmann kilchenmann changed the title feat(ontology): delete property from resource class (DSP-1854) feat(ontology): delete property from resource class (DSP-1854 / DEV-28) Oct 19, 2021
@kilchenmann kilchenmann requested a review from mdelez Oct 19, 2021
@kilchenmann kilchenmann removed the request for review from mdelez Oct 19, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Oct 19, 2021

@mdelez This PR is not yet ready for the review...now it's resolved and ready for a review

Loading

mdelez
mdelez approved these changes Oct 19, 2021
Copy link
Contributor

@mdelez mdelez left a comment

Looks good!

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Oct 19, 2021

Looks good!

Thanks

Loading

@kilchenmann kilchenmann merged commit 436c270 into main Oct 19, 2021
12 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1854-delete-cardinality branch Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants