Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): display incoming links (DSP-1846) #507

Merged
merged 8 commits into from Aug 17, 2021

Conversation

@Vijeinath
Copy link
Contributor

@Vijeinath Vijeinath commented Aug 13, 2021

resolves DSP-1846

I added also a pagination to use in case there are more than 25 incoming links

Loading
@@ -166,6 +166,15 @@
color: rgba(0, 0, 0, 0.54);
}

:host::ng-deep .mat-paginator-container {
Copy link
Collaborator

@kilchenmann kilchenmann Aug 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ng-deep is deprecated. It would be a better way to define/overwrite component's style in one of the global stylesheets in the assets folder. But for the moment you can keep it as it is.

Loading

Copy link
Contributor Author

@Vijeinath Vijeinath Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I keep this for the moment. Is there an alternative?

Loading

Copy link
Contributor

@mdelez mdelez Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no alternative for ng-deep and it doesn't appear as if there ever will be an alternative so you'll have to overwrite the component's style either in one of the global style sheets (recommended) or directly in the stylesheet of the component

Loading

Loading
mdelez
mdelez approved these changes Aug 17, 2021
Loading
@@ -166,6 +166,15 @@
color: rgba(0, 0, 0, 0.54);
}

:host::ng-deep .mat-paginator-container {
Copy link
Contributor

@mdelez mdelez Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no alternative for ng-deep and it doesn't appear as if there ever will be an alternative so you'll have to overwrite the component's style either in one of the global style sheets (recommended) or directly in the stylesheet of the component

Loading

@Vijeinath Vijeinath merged commit 9c3abce into main Aug 17, 2021
8 checks passed
Loading
@Vijeinath Vijeinath deleted the wip/DSP-1846-list-incoming-links branch Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants