Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(action): migrate action module (DSP-1852) #509

Merged
merged 11 commits into from Aug 19, 2021

Conversation

@mdelez
Copy link
Contributor

@mdelez mdelez commented Aug 17, 2021

resolves DSP-1852

- _viewer.scss
- statusMsg.ts
- confirmation-dialog comp
- confirmation-message comp
- login-form comp
- notification service
- sorting service
@mdelez mdelez self-assigned this Aug 17, 2021
@mdelez mdelez requested a review from subotic Aug 18, 2021
@mdelez
Copy link
Contributor Author

@mdelez mdelez commented Aug 18, 2021

@subotic it's a ton of code but it's all code that we already know works. This PR is a simple migration of the code from the ui-lib, it does not update the imports within dsp-app to use this migrated code. That will happen in a future PR since I will basically touch every file.

Loading

@mdelez mdelez merged commit 725c45e into main Aug 19, 2021
8 checks passed
Loading
@mdelez mdelez deleted the wip/DSP-1852-migrate-action-module branch Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants