Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): new date picker (DEV-112) #532

Merged
merged 45 commits into from Oct 14, 2021
Merged

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Sep 12, 2021

resolves DEV-112

previous task DSP-1769

@kilchenmann kilchenmann self-assigned this Sep 12, 2021
@kilchenmann kilchenmann marked this pull request as draft Sep 12, 2021
@kilchenmann kilchenmann marked this pull request as ready for review Oct 7, 2021
@kilchenmann kilchenmann changed the title feat(resource): new date picker (DSP-1769) feat(resource): new date picker (DEV-112) Oct 7, 2021
@kilchenmann kilchenmann requested a review from mdelez Oct 7, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Oct 13, 2021

@mdelez I just fixed the expressionChangedAfterItHasBeenCheckedError we had in date period. Additional I've added the new date picker to the advanced search. Now everything should work and is ready to be reviewed.

Loading

Copy link
Contributor

@mdelez mdelez left a comment

Everything regarding the date picker works well! However, I noticed that the time value is broken now when I try to add or edit a value 😬 Does it work for you?
Screen Shot 2021-10-14 at 16 06 00

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Oct 14, 2021

Everything regarding the date picker works well! However, I noticed that the time value is broken now when I try to add or edit a value 😬 Does it work for you?
Screen Shot 2021-10-14 at 16 06 00

Hm, I haven't touch the time value. So, it seems to be a bug. Would you like to write a bug report it in Jira? This should be solved in a separate PR. Or is the time value somehow related to the date value?

Loading

@mdelez
Copy link
Contributor

@mdelez mdelez commented Oct 14, 2021

Everything regarding the date picker works well! However, I noticed that the time value is broken now when I try to add or edit a value 😬 Does it work for you?
Screen Shot 2021-10-14 at 16 06 00

Hm, I haven't touch the time value. So, it seems to be a bug. Would you like to write a bug report it in Jira? This should be solved in a separate PR. Or is the time value somehow related to the date value?

I'll create a bug report on Jira. Honestly the time value seems unnecessary but I suppose it's needed because of the old/current data. I'll approve this PR in the meantime 👍

Loading

@mdelez mdelez self-requested a review Oct 14, 2021
mdelez
mdelez approved these changes Oct 14, 2021
@kilchenmann kilchenmann merged commit 04e4b32 into main Oct 14, 2021
12 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dsp-1769-date-picker branch Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants