Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: openseadragon prod build fix (DSP-1779) #534

Merged
merged 9 commits into from Sep 17, 2021

Conversation

@mdelez
Copy link
Contributor

@mdelez mdelez commented Sep 15, 2021

resolves DSP-1779

@mdelez mdelez self-assigned this Sep 15, 2021
Copy link
Collaborator

@kilchenmann kilchenmann left a comment

wow! LGTM. Let's try....

Loading

@EricSommerhalder
Copy link
Contributor

@EricSommerhalder EricSommerhalder commented Sep 16, 2021

Looks good to me as well. I feel like we should document somewhere that we only support rectangular regions at the moment though. I'm not sure where.

Loading

@mdelez
Copy link
Contributor Author

@mdelez mdelez commented Sep 16, 2021

Looks good to me as well. I feel like we should document somewhere that we only support rectangular regions at the moment though. I'm not sure where.

Yeah, that's a good point. I'll check the docs and see if they can be updated.

Loading

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Sep 17, 2021

Looks good to me as well. I feel like we should document somewhere that we only support rectangular regions at the moment though. I'm not sure where.

Yeah, that's a good point. I'll check the docs and see if they can be updated.

The whole part about "Working with resources" is not yet written (or only partial). Here's the (data) user guide which has the be improved completely.

Loading

@mdelez mdelez merged commit 0a34eaa into main Sep 17, 2021
12 checks passed
Loading
@mdelez mdelez deleted the wip/DSP-1779-osd-prod-build-fix branch Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants