Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(properties): do not submit res instance form by adding new value (DEV-150) #553

Merged
merged 1 commit into from Oct 15, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Oct 15, 2021

resolves DEV-150

By default a button is defined as submit button. We can avoid it by define button type as button and / or to use the Event.preventDefault() method.

@kilchenmann kilchenmann self-assigned this Oct 15, 2021
@kilchenmann kilchenmann requested a review from mdelez Oct 15, 2021
mdelez
mdelez approved these changes Oct 15, 2021
Copy link
Contributor

@mdelez mdelez left a comment

thanks for the quick fix!

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Oct 15, 2021

thanks for the quick fix!

this was an easy one. Thank you for the quick review

Loading

@kilchenmann kilchenmann merged commit 99a3022 into main Oct 15, 2021
12 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dev-150-add-button-submit-resource-instance branch Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants