Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(value): refactor boolean value (DEV-98) #554

Merged
merged 13 commits into from Oct 20, 2021
Merged

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Oct 18, 2021

resolves DEV-98

Copy link
Contributor

@mdelez mdelez left a comment

It's not a big thing but it should be resolved in this PR. In the new resource instance form, the checkbox is not aligned with the property label:
Screen Shot 2021-10-19 at 15 11 49

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Oct 19, 2021

It's not a big thing but it should be resolved in this PR. In the new resource instance form, the checkbox is not aligned with the property label:
Screen Shot 2021-10-19 at 15 11 49

@mdelez resolved in 87b3bad

This styling issue was not an easy one. It was already bad in the previous version but I've never saw it. I had to improvising a bit.
Screen Shot 2021-10-19 at 15 56 11

Loading

@kilchenmann kilchenmann requested a review from mdelez Oct 19, 2021
@mdelez
Copy link
Contributor

@mdelez mdelez commented Oct 19, 2021

It's not a big thing but it should be resolved in this PR. In the new resource instance form, the checkbox is not aligned with the property label:
Screen Shot 2021-10-19 at 15 11 49

@mdelez resolved in 87b3bad

This styling issue was not an easy one. It was already bad in the previous version but I've never saw it. I had to improvising a bit. Screen Shot 2021-10-19 at 15 56 11

I figured it wouldn't be the easiest thing to align but your improvisation looks good :)

Loading

mdelez
mdelez approved these changes Oct 19, 2021
@kilchenmann kilchenmann merged commit 7affa5e into main Oct 20, 2021
12 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/dev-98-boolean-checkbox branch Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants