Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(value): fix boolean value issue #557

Merged
merged 6 commits into from Oct 20, 2021
Merged

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Oct 20, 2021

resolves DEV-155

  • if a boolean value does not exist (e.g. because the property was added later to the res class) it should still show the add button.

  • For the same reason we had to re-activate the "exist" comparison operator in the advanced search

  • a boolean value cannot be deleted anymore. In this PR I disabled the delete button in this case

@kilchenmann kilchenmann self-assigned this Oct 20, 2021
@kilchenmann kilchenmann added bug A bug fix enhancement New feature or request labels Oct 20, 2021
@kilchenmann kilchenmann requested a review from mdelez Oct 20, 2021
@kilchenmann kilchenmann merged commit 4d35cd2 into main Oct 20, 2021
12 checks passed
@kilchenmann kilchenmann deleted the fix/dev-155-boolean-value branch Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants