Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(still-image): display iiif url under the image caption (DEV-243) #613

Merged
merged 3 commits into from Dec 9, 2021

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Dec 8, 2021

resolves DEV-243

@mdelez mdelez added the enhancement New feature or request label Dec 8, 2021
@mdelez mdelez self-assigned this Dec 8, 2021
@mdelez mdelez requested a review from kilchenmann as a code owner Dec 8, 2021
Copy link
Contributor

@kilchenmann kilchenmann left a comment

just one remark. Otherwise it looks good

<span class="caption mat-caption">{{imageCaption}}</span>
</div>
<div class="bottom">
<span class="iiif mat-caption">{{iiifUrl}}</span>
Copy link
Contributor

@kilchenmann kilchenmann Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to define it as a link to open the image in a new tab. because it could be confusing to see an url that is not clickable 😉

Copy link
Collaborator Author

@mdelez mdelez Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kilchenmann I had the same thought! Added in 5f1cf90 😉

@mdelez mdelez merged commit 109978f into main Dec 9, 2021
13 checks passed
@mdelez mdelez deleted the wip/dev-243-display-iiif-url-still-image branch Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants