Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): display deleted resource (DEV-299) #632

Merged
merged 7 commits into from Jan 14, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jan 12, 2022

resolves DEV-299

@kilchenmann kilchenmann marked this pull request as draft Jan 12, 2022
@kilchenmann kilchenmann added dependencies Pull requests that update a dependency file enhancement New feature or request labels Jan 12, 2022
@kilchenmann kilchenmann self-assigned this Jan 12, 2022
@kilchenmann kilchenmann changed the title feat(resource): display deleted resource (DEV-2990 feat(resource): display deleted resource (DEV-299) Jan 12, 2022
@kilchenmann kilchenmann marked this pull request as ready for review Jan 14, 2022
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jan 14, 2022

This is how it works:

Normal Resource Screen Shot 2022-01-14 at 09 23 41

Click on Delete Resource
Screen Shot 2022-01-14 at 09 23 48

Dialog box to confirm and to set a comment
Screen Shot 2022-01-14 at 09 24 54

Status after deleting resource
Screen Shot 2022-01-14 at 09 25 01

NEW Deleted resource when opening from ARK-URL (or after refreshing page)
Screen Shot 2022-01-14 at 09 25 11

@@ -34,7 +34,7 @@
</div>

<!-- tabs -->
<mat-tab-group animationDuration="0ms" [(selectedIndex)]="selectedTab" (selectedTabChange)="tabChanged($event)">
<mat-tab-group *ngIf="!resource.res.isDeleted; else deletedResource" animationDuration="0ms" [(selectedIndex)]="selectedTab" (selectedTabChange)="tabChanged($event)">
Copy link
Collaborator

@mdelez mdelez Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also have a similar ngIf for the representation div of this file. As it is now, if I delete a resource with some sort of resource representation (audio, document, image, archive, etc.), I still see the representation. The resource representation is only hidden once I refresh the page.

Copy link
Contributor Author

@kilchenmann kilchenmann Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, you're right. I'll update asap

Copy link
Contributor Author

@kilchenmann kilchenmann Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. When deleting a resource, it's still visible as it was before (incl. all property values etc) because I do not get the updated resource information yet. In comparison to the current view of a deleted resource does not have any property and value information. But Rebecca is working on a better version, that we still get the whole resource information even when it's deleted. The current implementation in this PR is only a temporary solution to display something. In the previous version, the user was getting a blank page only.

@kilchenmann kilchenmann requested a review from mdelez Jan 14, 2022
mdelez
mdelez approved these changes Jan 14, 2022
@kilchenmann kilchenmann merged commit 2c5fd80 into main Jan 14, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-299-deleted-val-and-res branch Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants