Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): support partOf value to create book res class (DEV-180) #634

Merged
merged 11 commits into from Jan 18, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jan 14, 2022

resolves DEV-180

@kilchenmann kilchenmann self-assigned this Jan 14, 2022
@kilchenmann kilchenmann added dependencies Pull requests that update a dependency file enhancement New feature or request labels Jan 14, 2022
@kilchenmann kilchenmann marked this pull request as draft Jan 14, 2022
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jan 14, 2022

we have to wait for new API release with fixed bug dasch-swiss/dsp-api#1978

@kilchenmann kilchenmann marked this pull request as ready for review Jan 18, 2022
@kilchenmann kilchenmann requested review from mdelez and removed request for mdelez Jan 18, 2022
@kilchenmann kilchenmann requested a review from mdelez Jan 18, 2022
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jan 18, 2022

@mdelez you'll need latest release of DSP-API (or main branch) if you want to test this feature. Please feel free to correct the new section in the documentation.

mdelez
mdelez approved these changes Jan 18, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

Works well for me!

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jan 18, 2022

Thank you @mdelez for updating the docs

@kilchenmann kilchenmann merged commit 3051a67 into main Jan 18, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-180-ontology-support-part-of branch Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants