Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: display dsp release number (DEV-420) #644

Merged
merged 12 commits into from Feb 2, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jan 30, 2022

resolves DEV-420

This PR contains a breaking change because it needs an updated version of the configuration.

@kilchenmann kilchenmann self-assigned this Jan 30, 2022
@kilchenmann kilchenmann added breaking Breaking Changes dependencies Pull requests that update a dependency file enhancement New feature or request labels Jan 30, 2022
@kilchenmann kilchenmann marked this pull request as draft Jan 31, 2022
@kilchenmann kilchenmann requested a review from mdelez Feb 1, 2022
@kilchenmann kilchenmann marked this pull request as ready for review Feb 1, 2022
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Feb 1, 2022

@mdelez I've attached the screenshots of the app in different environments directly to the jira-task description.

Copy link
Collaborator

@mdelez mdelez left a comment

Works well for me! Just some things to clean up :)

src/app/main/header/header.component.html Outdated Show resolved Hide resolved
src/app/main/header/header.component.ts Outdated Show resolved Hide resolved
@kilchenmann kilchenmann requested a review from mdelez Feb 2, 2022
mdelez
mdelez approved these changes Feb 2, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

Thank you for this, it's super helpful!

@kilchenmann kilchenmann merged commit b6c9f1c into main Feb 2, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-420-dsp-release-integration branch Feb 2, 2022
@daschbot daschbot mentioned this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants