Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): display permissions (DEV-454) #660

Merged
merged 15 commits into from Feb 17, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Feb 15, 2022

resolves DEV-454

@kilchenmann kilchenmann self-assigned this Feb 15, 2022
@kilchenmann kilchenmann marked this pull request as draft Feb 15, 2022
@kilchenmann kilchenmann requested a review from mdelez Feb 16, 2022
@kilchenmann kilchenmann added bug A bug fix enhancement New feature or request refactor Refactor or redesign labels Feb 16, 2022
@kilchenmann kilchenmann marked this pull request as ready for review Feb 16, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

Adding the test isn't crucial but it may be nice to have if we're going to be working with permissions at a later point in time so we know that this new component still works

@kilchenmann kilchenmann requested a review from mdelez Feb 17, 2022
mdelez
mdelez approved these changes Feb 17, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

Thanks!!

@kilchenmann kilchenmann merged commit 13a3a49 into main Feb 17, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-454-res-permissions branch Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix enhancement New feature or request refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants