Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permission-info): close permission info on scrolling (DEV-552) #671

Merged
merged 3 commits into from Feb 22, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Feb 22, 2022

The cdk-overlay-scrollstrategy was not working correctly. The reposition attribute was not useful. With this PR it will close the info box as soon the user scrolls (in Safari). There is one bad behaviour which I was not able to resolve. The the scroll event closes the info box, the user has to click twice on the permission button, because the isOpen status is still set to true. I couldn't find a good example to resolve this.

@kilchenmann kilchenmann requested a review from mdelez Feb 22, 2022
@kilchenmann kilchenmann self-assigned this Feb 22, 2022
@kilchenmann kilchenmann added the bug A bug fix label Feb 22, 2022
mdelez
mdelez approved these changes Feb 22, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

works great for me, thanks :)

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Feb 22, 2022

thank you!

@kilchenmann kilchenmann merged commit 8ac1d25 into main Feb 22, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/DEV-552-overlay-issue branch Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants