Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(still-image): IIIF URL copy button (DEV-524) #690

Merged
merged 3 commits into from Mar 22, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Mar 22, 2022

resolves DEV-524

@mdelez mdelez added the enhancement New feature or request label Mar 22, 2022
@mdelez mdelez requested a review from kilchenmann as a code owner Mar 22, 2022
@mdelez mdelez self-assigned this Mar 22, 2022
@mdelez mdelez changed the title feat(copy-button): IIIF URL copy button (DEV-524) feat(still-image): IIIF URL copy button (DEV-524) Mar 22, 2022
Copy link
Contributor

@kilchenmann kilchenmann left a comment

We should also use the notification service which pops up after clicking on the copy button. Same way as we did in the "Copy ARK URL".

Have a look at the properties.component.html where we have a click event (click)="openSnackBar('ARK URL copied to clipboard!')" and the corresponding openSnackBar method in properties.component.ts.

@mdelez
Copy link
Collaborator Author

mdelez commented Mar 22, 2022

We should also use the notification service which pops up after clicking on the copy button. Same way as we did in the "Copy ARK URL".

Have a look at the properties.component.html where we have a click event (click)="openSnackBar('ARK URL copied to clipboard!')" and the corresponding openSnackBar method in properties.component.ts.

done in 25bc724

@mdelez mdelez requested a review from kilchenmann Mar 22, 2022
@mdelez mdelez merged commit b0d72a6 into main Mar 22, 2022
13 checks passed
@mdelez mdelez deleted the wip/dev-524-iiif-url-copy-button branch Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants