Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(representation): implement video player incl. preview (DEV-701) #698

Merged
merged 28 commits into from Apr 22, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Mar 30, 2022

resolves DEV-701 and DEV-26

@kilchenmann kilchenmann self-assigned this Mar 30, 2022
@kilchenmann kilchenmann marked this pull request as draft Mar 30, 2022
@kilchenmann kilchenmann added the enhancement New feature or request label Mar 30, 2022
@kilchenmann kilchenmann requested a review from mdelez Apr 8, 2022
@kilchenmann kilchenmann marked this pull request as ready for review Apr 8, 2022
@kilchenmann kilchenmann marked this pull request as draft Apr 13, 2022
@kilchenmann kilchenmann marked this pull request as ready for review Apr 21, 2022
);

dialogRef.afterClosed().subscribe((data) => {
this._replaceFile(data);
Copy link
Collaborator

@mdelez mdelez Apr 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if data is undefined here, otherwise it breaks the video player. This is my fault actually and should be changed in each openReplaceFileDialog that I added in #695. Interestingly this didn't cause an issue with the other openReplaceFileDialog methods which is why I didn't catch it. Should I open a separate PR for this once this is merged?

Copy link
Contributor Author

@kilchenmann kilchenmann Apr 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do it in a separate task.
I can disable the "replace-file" button in this task to avoid crashing player.

Copy link
Contributor Author

@kilchenmann kilchenmann Apr 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved in a6527d4

@kilchenmann kilchenmann requested a review from mdelez Apr 21, 2022
mdelez
mdelez approved these changes Apr 22, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

Looks great! Thanks :)

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Apr 22, 2022

Thank you @mdelez 🎉

@kilchenmann kilchenmann merged commit 86fc2a7 into main Apr 22, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-701-video-player branch Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants