Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(help): update support links (DEV-779) #700

Merged
merged 6 commits into from Apr 7, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Apr 5, 2022

resolves DEV-779

@kilchenmann kilchenmann self-assigned this Apr 5, 2022
@kilchenmann kilchenmann added the refactor Refactor or redesign label Apr 5, 2022
@kilchenmann kilchenmann changed the title chore(help): update support links (DEV-658) refactor(help): update support links (DEV-658) Apr 5, 2022
@@ -143,6 +143,7 @@ describe('help page', () => {
}
}
// perform here any actions needed on the new tab
// --> TODO: why is still working? The address doesn't exist anymore. It was replaced by "mailto:support@dasch.swiss?subject=...."
Copy link
Contributor Author

@kilchenmann kilchenmann Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdelez Why is this test still working?

@kilchenmann kilchenmann requested a review from mdelez Apr 5, 2022
@kilchenmann kilchenmann changed the title refactor(help): update support links (DEV-658) refactor(help): update support links (DEV-779) Apr 5, 2022
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Apr 7, 2022

Reactivating e2e tests will be part of another task.
@mdelez: This PR can be merged soon, right?

mdelez
mdelez approved these changes Apr 7, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

let's merge this one and I'll create a Jira task to fix the e2e tests

@kilchenmann kilchenmann merged commit d97113f into main Apr 7, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-658-update-links branch Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants