Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource-instance-form): disable "next" button when form is not valid (DEV-803) #713

Merged
merged 4 commits into from Apr 13, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Apr 13, 2022

resolves DEV-803

…ion has been entered to proceed to the second step
@mdelez mdelez self-assigned this Apr 13, 2022
@mdelez mdelez marked this pull request as ready for review Apr 13, 2022
@mdelez mdelez requested a review from kilchenmann as a code owner Apr 13, 2022
@mdelez
Copy link
Collaborator Author

mdelez commented Apr 13, 2022

Screen.Recording.2022-04-13.at.10.38.40.mov

@kilchenmann I also added a progress indicator to clarify that something is happening in the background after the user selects something. If you want to try on your end, I recommend throttling your internet speed in the dev tools.

Copy link
Contributor

@kilchenmann kilchenmann left a comment

Just a small detail 😉

<button mat-raised-button type="button" color="primary"
[disabled]="!selectResourceForm.valid || this.errorMessage" (click)="nextStep()" class="form-next">
[disabled]="(!selectedProject || !selectedOntology || !selectedResourceClass || !selectResourceForm.valid) || this.errorMessage" (click)="nextStep()" class="form-next">
<app-progress-indicator *ngIf="loading" [status]="0" class="next-progress"></app-progress-indicator>
Copy link
Contributor

@kilchenmann kilchenmann Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set the color of the progress-indicator to primary? Just add [color]="'primary'"

Copy link
Collaborator Author

@mdelez mdelez Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 49ddae3

@mdelez mdelez merged commit 124b953 into main Apr 13, 2022
13 checks passed
@mdelez mdelez deleted the fix/dev-803-create-resource-next-button branch Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants