Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up jsDocs and delete deprecated methods (DEV-741) #722

Merged
merged 6 commits into from May 4, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented May 3, 2022

resolves DEV-741

@kilchenmann kilchenmann self-assigned this May 3, 2022
@kilchenmann kilchenmann requested a review from mdelez May 3, 2022
@kilchenmann kilchenmann added the refactor Refactor or redesign label May 3, 2022
mdelez
mdelez approved these changes May 4, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

Thanks for this! Just a small remark

@@ -76,10 +68,7 @@ export class SearchPanelComponent implements OnInit {
) { }

ngOnInit() {
Copy link
Collaborator

@mdelez mdelez May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need ngOnInit here?

Copy link
Contributor Author

@kilchenmann kilchenmann May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have it everywhere, even when it's empty. Should I remove all empty angular lifecycle hooks?

@kilchenmann kilchenmann merged commit 8457119 into main May 4, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-741-refactor branch May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants