Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): better progress indicator handling in resource viewer (DEV-638) #725

Merged
merged 2 commits into from May 5, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented May 4, 2022

resolves DEV-638

Especially in case of a book, where the incoming file representations have to be loaded first, it makes sense to display the whole resource when everything is ready.

Screen.Recording.2022-05-04.at.16.39.56.mov

@kilchenmann kilchenmann requested a review from mdelez May 4, 2022
@kilchenmann kilchenmann self-assigned this May 4, 2022
@kilchenmann kilchenmann added the enhancement New feature or request label May 4, 2022
@kilchenmann kilchenmann changed the title fix(resource): better progress indicator handling in resource viewer (DEV-638) feat(resource): better progress indicator handling in resource viewer (DEV-638) May 4, 2022
mdelez
mdelez approved these changes May 5, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

Looks good :)

@kilchenmann kilchenmann merged commit 946af20 into main May 5, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-638-better-progress-indicator-on-resource branch May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants