Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(message): use only one static error component (DEV-900) #727

Merged
merged 10 commits into from May 9, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented May 6, 2022

resolves DEV-900

@kilchenmann kilchenmann self-assigned this May 6, 2022
@kilchenmann kilchenmann added enhancement New feature or request refactor Refactor or redesign styling Update style; no production code change labels May 6, 2022
* test(error): add tests

* test(user): update tests

* test(user): update tests

* test(user): fix user form test
@kilchenmann
Copy link
Contributor Author

kilchenmann commented May 7, 2022

@mdelez would it make sense to rename the error-component into status-component, because it's not only used for errors. But we can discuss it on Monday.

@mdelez
Copy link
Collaborator

mdelez commented May 9, 2022

@mdelez would it make sense to rename the error-component into status-component, because it's not only used for errors. But we can discuss it on Monday.

maybe app-status would be more clear since "status" can be a bit ambiguous

@kilchenmann kilchenmann requested a review from mdelez May 9, 2022
@kilchenmann
Copy link
Contributor Author

kilchenmann commented May 9, 2022

ok, then I rename it

@kilchenmann
Copy link
Contributor Author

kilchenmann commented May 9, 2022

@mdelez the PR should be ready for review now

mdelez
mdelez approved these changes May 9, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

Thank you for this! A few remarks but then it can be merged.


.image,
.text {
justify-self: stretch;
align-self: stretch;
box-sizing: border-box;
padding: 24px;
// padding: 24px;
Copy link
Collaborator

@mdelez mdelez May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be removed?

Copy link
Contributor Author

@kilchenmann kilchenmann May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved in a3fdd23

this.success = true;

// this.loading = false;
this._notification.openSnackBar('You have successfully updated user\'s profile data.');
Copy link
Collaborator

@mdelez mdelez May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the user's profile data

Copy link
Contributor Author

@kilchenmann kilchenmann May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved in a3fdd23

@kilchenmann kilchenmann merged commit 404f1f6 into main May 9, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-900-refactor-message-concept branch May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactor or redesign styling Update style; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants